linux-kernel - Re: ALSA: nm256: Fine-tuning for three function implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk1yajij2.wl-tiwai@suse.de>
Date:   Tue, 28 Nov 2017 20:43:45 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     alsa-devel@...a-project.org,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: ALSA: nm256: Fine-tuning for three function implementations

On Tue, 28 Nov 2017 20:08:13 +0100,
SF Markus Elfring wrote:
> 
> >> Examples:
> >> * ALSA: cs5530: Use common error handling code in snd_cs5530_probe()
> >>   https://lkml.org/lkml/2017/11/18/266
> >>   https://patchwork.kernel.org/patch/10064945/
> >>   https://lkml.kernel.org/r/<a2cb6494-a01c-668a-cd9b-1a8428a0d4c9@...rs.sourceforge.net>
> > 
> > This is no trivial patch.
> 
> Why do you find this one more challenging now than a similar one?
> 
> ALSA: maestro3: Use common error handling code in two functions
> https://lkml.org/lkml/2017/9/6/39
> https://patchwork.kernel.org/patch/9939985/
> https://lkml.kernel.org/r/<83b1ba49-253d-72ed-b3b0-ec7d5e72a12c@...rs.sourceforge.net>

Because it turned out that your patch can be wrong and broken.


Takashi