linux-kernel - Re: [PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0770A301-E322-4F85-A0F6-8448DECBB258@fb.com>
Date:   Tue, 28 Nov 2017 21:38:49 +0000
From:   Nick Terrell <terrelln@...com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
CC:     Chris Mason <clm@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs


> On Nov 27, 2017, at 4:00 PM, Gustavo A. R. Silva <garsilva@...eddedor.com> wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Looks good to me. We had the same patch in upstream PR#690 [1].
I believe that PR#695 [2] was also necessary to quiet the warning.

[1] https://github.com/facebook/zstd/pull/690/files
[2] https://github.com/facebook/zstd/pull/695/files

Reviewed-by: Nick Terrell <terrelln@...com>