linux-kernel - Re: [PATCH] phy: rockchip-typec: add pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=Wt6iS7dxwmqiSX2ZB=THoujhXZJ2Tu8s0CZC4jp5_TTQ@mail.gmail.com>
Date:   Tue, 28 Nov 2017 14:02:01 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Chris Zhong <zyw@...k-chips.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Guenter Roeck <groeck@...omium.org>,
        wulf <wulf@...k-chips.com>,
        Brian Norris <briannorris@...omium.org>,
        Heiko Stübner <heiko@...ech.de>,
        "Kever.Yang" <kever.yang@...k-chips.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: rockchip-typec: add pm_runtime_disable in err case

Hi,

On Thu, Sep 8, 2016 at 10:38 AM, Chris Zhong <zyw@...k-chips.com> wrote:
> Add pm_runtime_disable in err case to make the pm_runtime_enable/disable
> is invoked balanced.
>
> Signed-off-by: Chris Zhong <zyw@...k-chips.com>
>
> ---
>
>  drivers/phy/phy-rockchip-typec.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/phy-rockchip-typec.c b/drivers/phy/phy-rockchip-typec.c
> index 7cfb0f8..dd257c7 100644
> --- a/drivers/phy/phy-rockchip-typec.c
> +++ b/drivers/phy/phy-rockchip-typec.c
> @@ -977,6 +977,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
>                 if (IS_ERR(phy)) {
>                         dev_err(dev, "failed to create phy: %s\n",
>                                 child_np->name);
> +                       pm_runtime_disable(dev);
>                         return PTR_ERR(phy);
>                 }
>
> @@ -986,6 +987,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
>         phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>         if (IS_ERR(phy_provider)) {
>                 dev_err(dev, "Failed to register phy provider\n");
> +               pm_runtime_disable(dev);
>                 return PTR_ERR(phy_provider);
>         }
>
> --
> 1.9.1

The patch is a little stale, but it still tastes OK to me.  Maybe a
good time to land it?  :-P

Reviewed-by: Douglas Anderson <dianders@...omium.org>

-Doug