linux-kernel - Re: [PATCH] hwmon/coretemp: requires CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51c092a0-6eb1-2290-b331-7a1223e5e330@infradead.org>
Date:   Tue, 28 Nov 2017 14:32:16 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Rudolf Marek <r.marek@...embler.cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH] hwmon/coretemp: requires CONFIG_PCI

On 11/28/2017 01:41 PM, Guenter Roeck wrote:
> On Tue, Nov 28, 2017 at 09:39:02AM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix coretemp.c build when CONFIG_PCI is not enabled.
>> Fixes these build errors:
>>
>> ../drivers/hwmon/coretemp.c: In function 'adjust_tjmax':
>> ../drivers/hwmon/coretemp.c:250:9: error: implicit declaration of function 'pci_get_domain_bus_and_slot' [-Werror=implicit-function-declaration]
>>   struct pci_dev *host_bridge = pci_get_domain_bus_and_slot(0, 0, devfn);
>> ../drivers/hwmon/coretemp.c:250:32: warning: initialization makes pointer from integer without a cast [enabled by default]
>>   struct pci_dev *host_bridge = pci_get_domain_bus_and_slot(0, 0, devfn);
>>
> 
> nack, sorry.

No problem.

> The dependency is artificial, and the code using it is only needed for old
> CPUs. There should be a dummy function for pci_get_domain_bus_and_slot()
> if PCI is disabled, similar to pci_get_bus_and_slot() and all the other
> pci functions. If that is unacceptable for some reason, I rather revert
> the patch introducing the use of pci_get_domain_bus_and_slot().

I sent a patch with that function stub addition.

> After all, it doesn't add any real value to enforce the use of
> pci_get_domain_bus_and_slot() in the driver, a dummy function for
> pci_get_bus_and_slot() _is_ available, and the new function is quite
> obviously not a 1:1 replacement of pci_get_bus_and_slot().
> 
> Guenter
> 
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Rudolf Marek <r.marek@...embler.cz>
>> Cc: Jean Delvare <jdelvare@...e.com>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: linux-hwmon@...r.kernel.org
>> Cc: Fenghua Yu <fenghua.yu@...el.com>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> ---
>>  drivers/hwmon/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)


-- 
~Randy