[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5A1DF26E.6040306@linux.intel.com>
Date: Wed, 29 Nov 2017 07:34:06 +0800
From: Lu Baolu <baolu.lu@...ux.intel.com>
To: Felipe Balbi <felipe.balbi@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade
circular buffer
Hi Felipe,
On 11/28/2017 04:05 PM, Felipe Balbi wrote:
> Hi,
>
> Lu Baolu <baolu.lu@...ux.intel.com> writes:
>> The kernel FIFO implementation, kfifo, provides interfaces to manipulate
>> a first-in-first-out circular buffer. Use kfifo instead of the homemade
>> one to make the code more concise and readable.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> Thanks :-) Can you give a little description of how you tested this?
>
I tested it on an Intel Skylake box. On the gadget side, I loaded a serial
device (#modprobe g_serial). And then, connected it with a host.
On the gadget side, I run below scripts:
#!/bin/bash
for j in `seq 1 200`;
do
for i in `seq 1 50000`;
do
echo $i.$j > /dev/ttyGS0
done
done
And, on the host side,
#cat /dev/ttyACM0
Best regards,
Lu Baolu
Powered by blists - more mailing lists