linux-kernel - Re: [PATCH 0/5] add printk specifier %px, unique identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874lpelxzh.fsf@xmission.com>
Date:   Tue, 28 Nov 2017 00:26:58 -0600
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     "Tobin C. Harding" <me@...in.cc>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        "Theodore Ts'o" <tytso@....edu>, Kees Cook <keescook@...omium.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Tycho Andersen <tycho@...ho.ws>,
        "Roberts\, William C" <william.c.roberts@...el.com>,
        Tejun Heo <tj@...nel.org>,
        Jordan Glover <Golden_Miller83@...tonmail.ch>,
        Greg KH <gregkh@...uxfoundation.org>,
        Petr Mladek <pmladek@...e.com>, Joe Perches <joe@...ches.com>,
        Ian Campbell <ijc@...lion.org.uk>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <wilal.deacon@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Chris Fries <cfries@...gle.com>,
        Dave Weinstein <olorin@...gle.com>,
        Daniel Micay <danielmicay@...il.com>,
        Djalal Harouni <tixxdz@...il.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KVM list <kvm@...r.kernel.org>,
        "kernel-hardening\@lists.openwall.com" 
        <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH 0/5] add printk specifier %px, unique identifier

Linus Torvalds <torvalds@...ux-foundation.org> writes:

> On Mon, Nov 27, 2017 at 4:03 PM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> So the big remaining ones for me are the /proc/<pid>/stack (stack
>> pointers) and the /proc/net/* ones.
>>
>> I'm a bit disappointed that those haven't been fixed already and
>> aren't even in this series..
>
> Oh well, I just did /proc/<pid>/stack by making it just print 0
> unconditionally rather than the hex number.

Patch?

I know I have used /proc/<pid>/stack manually many times when looking
at a system where something is hung/weird and I needed to see what is
going on.  The backtrace inside the kernel can be invaluable.

At the same time I don't know if we actually need the hex address.
But please don't break that interface it is very useful.


Eric