linux-kernel - Re: [PATCH 2/3] ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hd142luzo.wl-tiwai@suse.de>
Date:   Tue, 28 Nov 2017 08:31:39 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "SF Markus Elfring" <elfring@...rs.sourceforge.net>
Cc:     <alsa-devel@...a-project.org>, "Kees Cook" <keescook@...omium.org>,
        "Alexey Dobriyan" <adobriyan@...il.com>,
        "Bhumika Goyal" <bhumirks@...il.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        <kernel-janitors@...r.kernel.org>,
        "LKML" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_create()

On Thu, 16 Nov 2017 12:52:41 +0100,
SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 16 Nov 2017 11:22:26 +0100
> 
> The function "release_firmware" is called in the current implementation of
> the function "_request_firmware" after a failure was detected.
> Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196
> 
> Such a call should therefore not be repeated directly after the
> corresponding error information was received in the local variable "err"
> of the function "snd_korg1212_create".
> Thus remove a misplaced function call.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Applied, thanks.


Takashi