linux-kernel - Re: [PATCH] mm/vmscan: change return type of is_page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171128080434.z32gfedrzq37rsqe@dhcp22.suse.cz>
Date:   Tue, 28 Nov 2017 09:04:34 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Jiang Biao <jiang.biao2@....com.cn>
Cc:     akpm@...ux-foundation.org, hannes@...xchg.org,
        hillf.zj@...baba-inc.com, minchan@...nel.org, ying.huang@...el.com,
        mgorman@...hsingularity.net, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, zhong.weidong@....com.cn
Subject: Re: [PATCH] mm/vmscan: change return type of is_page_cache_freeable
 from int to bool

On Tue 28-11-17 10:48:27, Jiang Biao wrote:
> Using bool for the return type of is_page_cache_freeable() should be
> more appropriate.

Does this help to generate a better code or why do we want to change
this at all?

> Signed-off-by: Jiang Biao <jiang.biao2@....com.cn>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index eb2f031..5fe63ed 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -530,7 +530,7 @@ void drop_slab(void)
>  		drop_slab_node(nid);
>  }
>  
> -static inline int is_page_cache_freeable(struct page *page)
> +static inline bool is_page_cache_freeable(struct page *page)
>  {
>  	/*
>  	 * A freeable page cache page is referenced only by the caller
> -- 
> 2.7.4
> 

-- 
Michal Hocko
SUSE Labs