linux-kernel - Re: [PATCH] mm/page_owner: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171128081435.errtatm3nm36zq24@dhcp22.suse.cz>
Date:   Tue, 28 Nov 2017 09:14:35 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     vbabka@...e.cz, akpm@...ux-foundation.org,
        gregkh@...uxfoundation.org, tglx@...utronix.de,
        vinmenon@...eaurora.org, guptap@...eaurora.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_owner: Use PTR_ERR_OR_ZERO()

On Tue 28-11-17 00:08:21, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> mm/page_owner.c:639:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci

OK, this is easier to read. Is this the only place that we have in the
mm tree? I do not see more patches on linux-mm mailing list.

> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  mm/page_owner.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 4f44b95b9d1e..79ae586d1bce 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -636,9 +636,7 @@ static int __init pageowner_init(void)
>  
>  	dentry = debugfs_create_file("page_owner", S_IRUSR, NULL,
>  			NULL, &proc_page_owner_operations);
> -	if (IS_ERR(dentry))
> -		return PTR_ERR(dentry);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(dentry);
>  }
>  late_initcall(pageowner_init)
> -- 
> 1.9.1
> 

-- 
Michal Hocko
SUSE Labs