[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20171128083555.GA2807@himanshu-Vostro-3559>
Date: Tue, 28 Nov 2017 14:05:55 +0530
From: Morgan Freeman <morganfreeman6991@...il.com>
To: Ashish Kalra <eashishkalra@...il.com>
Cc: zajec5@...il.com, linux-wireless@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers: bcma: driver_pcie2.c: Comment format
correction & moving trailing */ to a separate line as per checkpatch
Hi Ashish,
On Tue, Nov 28, 2017 at 07:41:42AM +0530, Ashish Kalra wrote:
> This patch fixes the checkpatch.pl warning:
Write in _imperative_mood_ as I said before.
Like "Use this..." or "Make this..."
> WARNING: Block comments use * on subsequent lines
> + /* TODO:
> + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */
>
> WARNING: Block comments use a trailing */ on a separate line
> + si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */
>
> total: 0 errors, 2 warnings, 200 lines checked
No need to mention all of this!
> Signed-off-by: Ashish Kalra <eashishkalra@...il.com>
> ---
> changes from v1 (https://lkml.org/lkml/2017/11/26/85)
> v2: Improved commit message as per review from Morgan Freeman <morganfreeman6991@...il.com>
Your patch subject is again *wrong* here.
Look here: https://pastebin.com/X7x89Q4v
Please take a look at this :
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Also, don't send me the patch directly, instead to the relevant maintainer and
CC me.
Thanks
Himanshu Jha
Powered by blists - more mailing lists