linux-kernel - Re: sunrpc: infinite unkillable console spam in xs_tcp_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 11:00:56 +0100
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Trond Myklebust <trondmy@...marydata.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jlayton@...nel.org" <jlayton@...nel.org>,
        "bfields@...ldses.org" <bfields@...ldses.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "anna.schumaker@...app.com" <anna.schumaker@...app.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "syzkaller@...glegroups.com" <syzkaller@...glegroups.com>
Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket

On Fri, Nov 24, 2017 at 6:34 PM, Trond Myklebust
<trondmy@...marydata.com> wrote:
> On Mon, 2017-11-20 at 14:02 +0100, Dmitry Vyukov wrote:
>> Hello,
>>
>> The following program triggers infinite stream of the following
>> output
>> on console. The program is unkillable and this effectively brings the
>> machine down:
>>
>>
>> ** 16 printk messages dropped ** [12875.022917] xs_tcp_setup_socket:
>> connect returned unhandled error -113
>>
>
> Does the following fix the issue?


Re-run the provided reproducer with the patch.
I don't see any kernel output and the process is perfectly killable now.

Tested-by: Dmitry Vyukov <dvyukov@...gle.com>





> 8<-----------------------------------------------------
> From f48d3f01df45f50f0145060f5272ccf1aea855ac Mon Sep 17 00:00:00 2001
> From: Trond Myklebust <trond.myklebust@...marydata.com>
> Date: Fri, 24 Nov 2017 12:00:24 -0500
> Subject: [PATCH] SUNRPC: Allow connect to return EHOSTUNREACH
>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@...marydata.com>
> ---
>  net/sunrpc/xprtsock.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 4dad5da388d6..8cb40f8ffa5b 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -2437,6 +2437,7 @@ static void xs_tcp_setup_socket(struct work_struct *work)
>         case -ECONNREFUSED:
>         case -ECONNRESET:
>         case -ENETUNREACH:
> +       case -EHOSTUNREACH:
>         case -EADDRINUSE:
>         case -ENOBUFS:
>                 /*
> --
> 2.14.3
>
> --
> Trond Myklebust
> Linux NFS client maintainer, PrimaryData
> trond.myklebust@...marydata.com