linux-kernel - Re: [PATCH 1/5] docs: correct documentation for %pK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKurtT0ipe6V6_+9OSWQ0R=DiXz6Wxp+Bb=kjxhUxVamg@mail.gmail.com>
Date:   Mon, 27 Nov 2017 16:46:35 -0800
From:   Kees Cook <keescook@...omium.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        "Theodore Ts'o" <tytso@....edu>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Tycho Andersen <tycho@...ho.ws>,
        "Roberts, William C" <william.c.roberts@...el.com>,
        Tejun Heo <tj@...nel.org>,
        Jordan Glover <Golden_Miller83@...tonmail.ch>,
        Greg KH <gregkh@...uxfoundation.org>,
        Petr Mladek <pmladek@...e.com>, Joe Perches <joe@...ches.com>,
        Ian Campbell <ijc@...lion.org.uk>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <wilal.deacon@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Chris Fries <cfries@...gle.com>,
        Dave Weinstein <olorin@...gle.com>,
        Daniel Micay <danielmicay@...il.com>,
        Djalal Harouni <tixxdz@...il.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>,
        kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH 1/5] docs: correct documentation for %pK

On Mon, Nov 27, 2017 at 3:40 PM, Tobin C. Harding <me@...in.cc> wrote:
> Current documentation indicates that %pK prints a leading '0x'. This is
> not the case.
>
> Correct documentation for printk specifier %pK.

Yup, quite true. :)

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

>
> Signed-off-by: Tobin C. Harding <me@...in.cc>
> ---
>  Documentation/printk-formats.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.txt
> index 361789df51ec..b4fe3c5f3b44 100644
> --- a/Documentation/printk-formats.txt
> +++ b/Documentation/printk-formats.txt
> @@ -91,7 +91,7 @@ Kernel Pointers
>
>  ::
>
> -       %pK     0x01234567 or 0x0123456789abcdef
> +       %pK     01234567 or 0123456789abcdef
>
>  For printing kernel pointers which should be hidden from unprivileged
>  users. The behaviour of ``%pK`` depends on the ``kptr_restrict sysctl`` - see
> --
> 2.7.4
>



-- 
Kees Cook
Pixel Security