linux-kernel - Re: [PATCH v3 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 12:16:47 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM
 support

On 27/11/2017 13:57, Fabio Estevam wrote:
> On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong
> <narmstrong@...libre.com> wrote:
> 
>> +&pcie {
>> +       fsl,tx-swing-full = <103>;
>> +       fsl,tx-swing-low = <103>;
>> +       reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>;
> 
> This can only be active high if 'reset-gpio-active-high' property is
> present, so what you
> want here is:
>   reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
> 
> With this fixed:
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@....com>
> 

Ok,

I will post a v4 lately with this fixed.

Thanks,
Neil