linux-kernel - Re: [PATCH v2 07/10] perf stat: Allocate shadow stats buffer for threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e890f93-a688-c2d5-4b0c-18801d15a274@linux.intel.com>
Date:   Tue, 28 Nov 2017 20:23:14 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2 07/10] perf stat: Allocate shadow stats buffer for
 threads



On 11/28/2017 7:12 PM, Jiri Olsa wrote:
> On Mon, Nov 27, 2017 at 10:07:27PM +0800, Jin Yao wrote:
>> After perf_evlist__create_maps() being executed, we can get all
>> threads from /proc. And via thread_map__nr(), we can also get
>> the number of threads.
>>
>> With the number of threads, the patch allocates a buffer which
>> will record the shadow stats for these threads.
>>
>> The buffer pointer is saved in stat_config.
> 
> why don't you add struct perf_stat_config::*stats|stats_num in this patch?
> I dont see any reason it's introduced earlier
> 
> jirka
> 

OK, let me check it.

Thanks
Jin Yao