linux-kernel - Re: [PATCH] staging: most: Fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 13:31:42 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Chris Coffey <cmc@...blebit.net>
Cc:     devel@...verdev.osuosl.org,
        Christian Gromm <christian.gromm@...rochip.com>,
        linux-kernel@...r.kernel.org,
        Michael Fabry <Michael.Fabry@...rochip.com>
Subject: Re: [PATCH] staging: most: Fix build errors

On Tue, Nov 28, 2017 at 12:12:47PM +0000, Chris Coffey wrote:
> On Tue, Nov 28, 2017 at 08:26:07AM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Nov 27, 2017 at 09:12:39PM +0000, Chris Coffey wrote:
> > > This patch fixes build errors that occur when trying to build the
> > > MOST modules. For example, the cdev module build fails with:
> > > 
> > > make[3]: *** No rule to make target 'drivers/staging/most/aim-cdev/cdev.o', needed by 'drivers/staging/most/aim-cdev/aim_cdev.o'.  Stop.
> > > scripts/Makefile.build:569: recipe for target 'drivers/staging/most/aim-cdev' failed
> > > make[2]: *** [drivers/staging/most/aim-cdev] Error 2
> > > scripts/Makefile.build:569: recipe for target 'drivers/staging/most' failed
> > > make[1]: *** [drivers/staging/most] Error 2
> > > Makefile:1502: recipe for target '_module_drivers/staging' failed
> > > make: *** [_module_drivers/staging] Error 2
> > 
> > How are you seeing this error?  What is the build command line that you
> > provided to do this?  It should just "not build" right now at all.
> > 
> 
> I did a git pull to get the latest staging updates, enabled a bunch of
> staging drivers, and then ran a build on the staging modules with 'make
> modules M=drivers/staging'. Unfortunately now I'm unable to reproduce
> the error (of course).

If you run 'make' it would have fixed up the dependancies and not caused
a build error.  That makes sense how you saw it, but it's not there for
anyone else so all is fine.

> > > Update the Makefile variables and paths with the new directory
> > > structure to fix these errors.
> > > 
> > > Signed-off-by: Chris Coffey <cmc@...blebit.net>
> > > ---
> > >  drivers/staging/most/Makefile | 14 +++++++-------
> > >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > I think a patch was sent yesterday to fix these up, did you see it in
> > the archives?
> 
> I checked the archives before making the patch, and didn't see anything
> MOST-related in there for the past few days. The patch below made the 
> build succeed and generate all of the MOST modules.

Subject: [PATCH 1/3] staging: most: fix Makefile
is the patch sent yesterday that should resolve this.  I'm going to go
apply it right now...

thanks,

greg k-h