linux-kernel - Re: jsm_tty: Fix a possible null pointer dereference in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <089a4b85-64e8-cb4a-c5f8-9abb2556e5e5@users.sourceforge.net>
Date:   Wed, 29 Nov 2017 19:19:05 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org
Cc:     Joe Perches <joe@...ches.com>,
        "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>,
        Jiri Slaby <jslaby@...e.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: jsm_tty: Fix a possible null pointer dereference in two functions

>> It's pretty unlikely, but it is an actual defect.
> 
> No it is not, those variables will never be set to NULL,
> so this can never be triggered.  Walk up the call chain.

If the involved software developers are convinced about the validity
of this pointer:

How do you think about to delete the following condition check
instead in the discussed function implementations?

	if (!ch)
		return;


Regards,
Markus