lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 29 Nov 2017 13:44:43 -0600
From:   Govinda Tatti <govinda.tatti@...cle.com>
To:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Jan Beulich <JBeulich@...e.com>
Cc:     Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset
 with 'do_flr' SysFS attribute

Thanks Konrad for your response. Please see below for my comments.

>>>> Well, that's more a question to Konrad as the maintainer.
>>>> Personally I'd prefer just "reset", as "pci" is redundant and "bus"
>>> Can't do 'reset'.
>> Why?
> B/c I forgot that this attribute is not per device, but on the module sub-directory:
>
> /sys/bus/pci/drivers/pciback/do_flr
>
> It can be indeed called 'reset'.

Good.  We will rename sysfs attribute from "do_flr" to "reset"

>>>> doesn't cover the slot variant.
>>> 'bus_reset' sounds lovely?
>> Lovely sounding or not, it may end up misleading, and even more so
>> if - like asked for - FLR would be tried first.
> Fair enough. Reset should work then.
So, we will use the following sequence to reset the requested 
device/function.

- FLR (as first option)
- BUS/SLOT reset (as fall-back option) if FLR is not supported or any 
issue with FLR

Cheers
GOVINDA

Powered by blists - more mailing lists