linux-kernel - Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=X=rZRqyotVCGM+LYoyzPMnizgvK_yATVhdxo6i3cViaw@mail.gmail.com>
Date:   Wed, 29 Nov 2017 12:52:27 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Heiko Stübner <heiko@...ech.de>,
        Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Yannick Fertre <yannick.fertre@...com>,
        Philippe Cornu <philippe.cornu@...com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Vincent Abriou <vincent.abriou@...com>,
        dri-devel@...ts.freedesktop.org,
        LKML <linux-kernel@...r.kernel.org>,
        Sean Paul <seanpaul@...omium.org>,
        Nickey Yang <nickey.yang@...k-chips.com>,
        Lin Huang <hl@...k-chips.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, hoegsberg@...il.com,
        Chris <zyw@...k-chips.com>, xbl@...k-chips.com
Subject: Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

Hi,

On Wed, Nov 29, 2017 at 10:47 AM, Brian Norris <briannorris@...omium.org> wrote:
> From: Nickey Yang <nickey.yang@...k-chips.com>
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>    independent of the driver refactoring
>
> Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

This seems sane to me according to my current understanding and
reading of the bindings.

Reviewed-by: Douglas Anderson <dianders@...omium.org>