linux-kernel - Re: [PATCH v1] USB: storage: Notify the subdrivers that they need to reinitialize the device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Nov 2017 16:11:40 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Mikhail Zaytsev <flashed@...l.ru>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>,
        <usb-storage@...ts.one-eyed-alien.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] USB: storage: Notify the subdrivers that they need
 to reinitialize the device.

On Thu, 30 Nov 2017, Mikhail Zaytsev wrote:

> On Wed, 29 Nov 2017 Alan Stern <stern@...land.harvard.edu> wrote:
> 
> > On Wed, 29 Nov 2017, Mikhail Zaytsev wrote:
> > 
> > > This patch adds the device_reinit function into the us_data
> > > structure. The usb-storage driver uses this function for notify the
> > > subdrivers that they need to reinitialize the device.
> > > 
> > > Signed-off-by: Mikhail Zaytsev <flashed@...l.ru>  
> > 
> > I'd feel more inclined to accept this patch if the new code got used 
> > somewhere.  As it is, it fixes a "problem" that doesn't actually have 
> > any real effect.
> > 
> > Alan Stern
> 
> I propose to delete this FIXME comments without any code changes.

Okay.  You could leave a comment saying that if any of the subdrivers 
implemented a reinitialization scheme, this is where the callback would 
be invoked.

Alan Stern