linux-kernel - Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe447cdd-767e-0211-f20c-f1ce74a0841b@bitmath.org>
Date:   Wed, 29 Nov 2017 23:33:58 +0100
From:   Henrik Rydberg <rydberg@...math.org>
To:     Wei-Ning Huang <wnhuang@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Input <linux-input@...r.kernel.org>
Cc:     Dmitry Torokhov <dtor@...omium.org>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Peter Hutterer <peter.hutterer@...-t.net>,
        Wei-Ning Huang <wnhuang@...gle.com>, dmitry.torokhov@...il.com,
        corbet@....net, linux-doc@...r.kernel.org
Subject: Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation
 reporting

On 10/12/2017 08:21 AM, Wei-Ning Huang wrote:
> From: Wei-Ning Huang <wnhuang@...omium.org>
>
> The current hid-multitouch driver only allow the report of two
> orientations, vertical and horizontal. We use the Azimuth orientation
> usage 0x3F under the Digitizer usage page to report orientation if the
> device supports it.
>
> Changelog:
>    v1 -> v2:
>     - Fix commit message.
>     - Remove resolution reporting for ABS_MT_ORIENTATION.
>    v2 -> v3:
>     - Fix commit message.
>    v3 -> v4:
>     - Fix ABS_MT_ORIENTATION ABS param range.
>     - Don't set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already
>       set by ABS_DG_AZIMUTH.
>    v4 -> v5:
>     - Improve multi-touch-protocol.rst documentation.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@...omium.org>
> Signed-off-by: Wei-Ning Huang <wnhuang@...gle.com>
> Reviewed-by: Dmitry Torokhov <dtor@...omium.org>
> ---
>   Documentation/input/multi-touch-protocol.rst |  9 ++---
>   drivers/hid/hid-multitouch.c                 | 52 +++++++++++++++++++++++++---
>   include/linux/hid.h                          |  1 +
>   3 files changed, 54 insertions(+), 8 deletions(-)

    Reviewed-by: Henrik Rydberg <rydberg@...math.org>

Thank you, Wei-Ning, and sorry for the delay. Dmitry, did you plan to 
add this to your pull request already?

Henrik