linux-kernel - Re: [PATCH] crypto: chelsio: remove redundant assignments to reqctx and dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171129063109.GA21575@gondor.apana.org.au>
Date:   Wed, 29 Nov 2017 17:31:09 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Colin King <colin.king@...onical.com>
Cc:     Harsh Jain <harsh@...lsio.com>,
        "David S . Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: chelsio: remove redundant assignments to reqctx
 and dst_size

On Thu, Nov 09, 2017 at 08:54:13AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer reqctx is assigned the same value twice, once on initialization
> and again a few statements later, remove the second redundant assignment.
> Variable dst_size is assigned but it is never read, so the variable is
> redundant and can be removed. Cleans up clang warnings:
> 
> drivers/crypto/chelsio/chcr_algo.c:156:29: warning: Value stored to
> 'reqctx' during its initialization is never read
> drivers/crypto/chelsio/chcr_algo.c:2020:2: warning: Value stored to
> 'dst_size' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt