linux-kernel - Re: [PATCH v4 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hd141pjkt.wl-tiwai@suse.de>
Date:   Wed, 29 Nov 2017 09:36:50 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     " Maciej S. Szmigiero " <mail@...iej.szmigiero.name>
Cc:     "Nicolin Chen" <nicoleotsuka@...il.com>,
        "Xiubo Li" <Xiubo.Lee@...il.com>,
        "Jaroslav Kysela" <perex@...ex.cz>, "Timur Tabi" <timur@...i.org>,
        <alsa-devel@...a-project.org>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>, <linuxppc-dev@...ts.ozlabs.org>,
        "Fabio Estevam" <fabio.estevam@....com>,
        "Takashi Sakamoto" <o-takashi@...amocchi.jp>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S,U}20

On Mon, 27 Nov 2017 23:33:29 +0100,
 Maciej S. Szmigiero  wrote:
> 
> This format is similar to existing SNDRV_PCM_FORMAT_{S,U}20_3 that keep
> 20-bit PCM samples in 3 bytes, however i.MX6 platform SSI FIFO does not
> allow 3-byte accesses (including DMA) so a 4-byte (more conventional)
> format is needed for it.
> 
> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
> ---
> Changes from v1: Drop "_4" suffix from these formats since they aren't
> non-standard ones, use empty format slots starting from format number 25
> for them, add information that they are LSB justified formats.
> 
> Changes from v2: Adapt a comment in sound/core/pcm_misc.c so it still
> refers to the same sample formats as before.
> 
> Changes from v3: Make the comment style in include/uapi/sound/asound.h
> match the style of comments at other sample formats.
> 
> Corresponding alsa-lib changes will be posted as soon as this patch is
> merged on the kernel side, to keep alsa-lib and kernel synchronized.

Applied to topic/pcm-20bit, also included in for-next.

Mark, please pull topic/pcm-20bit branch if you need to apply fsl_ssi
patch into your tree.


thanks,

Takashi