linux-kernel - Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171128170817.1c23d420@cakuba.netronome.com>
Date:   Tue, 28 Nov 2017 17:08:40 -0800
From:   Jakub Kicinski <kubakici@...pl>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Matthew Wilcox <mawilcox@...rosoft.com>,
        Chris Mi <chrism@...lanox.com>, Jiri Pirko <jiri@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Eric Biggers <ebiggers@...gle.com>,
        Lai Jiangshan <laijs@...fujitsu.com>,
        Tejun Heo <tj@...nel.org>, Rehas Sachdeva <aquannie@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:
> +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> +						INT_MAX, GFP_KERNEL);
> +	} else if (!oldprog) {
> +		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
> +						handle, GFP_KERNEL);

nit: in many places you seem to not align the second line with opening
parenthesis.  Is that intentional?

FWIW there may be a small merge conflict with net on cls_bpf in patch
5, some of the code has been removed.