linux-kernel - Re: [PATCH v6 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1eff5a38-cff3-449b-bda4-047f50a9f1d4@EX17.ad.cirrus.com>
Date:   Wed, 29 Nov 2017 11:36:58 +0000
From:   Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        <alsa-devel@...a-project.org>,
        "open list:WOLFSON MICROELECTRONICS DRIVERS" 
        <patches@...nsource.wolfsonmicro.com>,
        <linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        Nikesh Oswal <Nikesh.Oswal@...fsonmicro.com>
Subject: Re: [PATCH v6 03/17] mfd: madera: Add common support for Cirrus Logic
 Madera codecs

On 29/11/17 10:18, Linus Walleij wrote:
> On Thu, Nov 23, 2017 at 6:13 PM, Richard Fitzgerald
> <rf@...nsource.wolfsonmicro.com> wrote:
> 
>> +config MFD_MADERA_I2C
>> +       bool "Cirrus Logic Madera codecs with I2C"
>> +       select MFD_MADERA
>> +       select REGMAP_I2C
>> +       depends on I2C
>> +       depends on PINCTRL
>> +       help
>> +         Support for the Cirrus Logic Madera platform audio SoC
>> +         core functionality controlled via I2C.
>> +
>> +config MFD_MADERA_SPI
>> +       bool "Cirrus Logic Madera codecs with SPI"
>> +       select MFD_MADERA
>> +       select REGMAP_SPI
>> +       depends on SPI_MASTER
>> +       depends on PINCTRL
>> +       help
>> +         Support for the Cirrus Logic Madera platform audio SoC
>> +         core functionality controlled via SPI.
> 
> Why do the I2C and SPI subdrivers depend on PINCTRL?
> 
> They sure don't seem to be using any pinctrl-specific APIs.
> 

They require PINCTRL even if they don't call any functions on it because 
the chip won't work correctly if there isn't a PINCTRL driver to apply 
the correct pinmux configuration.

> Yours,
> Linus Walleij
>