linux-kernel - Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1ea2772-c4fa-8b74-f6fb-04e5d2eeb38a@linux.intel.com>
Date:   Wed, 29 Nov 2017 14:39:19 +0200
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Ingo Molnar <mingo@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling
 with IRQ state tracing enabled

On 11/29/2017 11:28 AM, Thomas Gleixner wrote:
> On Wed, 29 Nov 2017, Jarkko Nikula wrote:
> 
>> On 11/29/2017 09:09 AM, Ingo Molnar wrote:
>>> Hm, that commit looks broken with irq-tracing enabled. Does the
>>> patch below fix it?
>>>
>> No, it makes the machine not to boot at all :-(
>>
>> Log below when I used my config (now attached). With x86_64_defconfig it
>> booted twice but didn't survive suspend/resume. However several other boot
>> attempts with x86_64_defconfig failed somewhat similarly. Not in the same
>> place but hanging anyway. With my own config it seems to always end up failing
>> in trace_hardirqs_off_caller.
> 
> Does it work when you disable all the tracing muck?
> 
My config seems to work with Ingo's patch if I disable both 
CONFIG_FTRACE and CONFIG_PROVE_LOCKING which disables the 
CONFIG_TRACE_IRQS_FLAGS.

x86_64_defconfig with CONFIG_FTRACE disabled is still unstable. 
Sometimes hangs during bootup and sometimes boots up to userspace.

-- 
Jarkko