linux-kernel - Re: [3/3] pinctrl: mcp23s08: Combine two function calls in mcp23s08_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2132d281-c4da-81b0-6dc7-4b42807cebf0@users.sourceforge.net>
Date:   Wed, 29 Nov 2017 15:04:31 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org
Cc:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [3/3] pinctrl: mcp23s08: Combine two function calls in
 mcp23s08_dbg_show()

>> * Print a line break together with other data in a single function call.
>>
>> * Adjust indentation.
…
> 
> This does not apply.
> Possibly depends on 2/3.

Partly, yes.


How do you think about the following possibilities?

* Omit two context lines at the end from this update step.
  or
* Refer to the jump label “done” (instead of renaming it to “unlock” before).


Would you try once more to integrate the shown small change?

Regards,
Markus