linux-kernel - Re: [PATCH net-next] vmxnet3: increase default rx ring sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171129.091448.2012623126704239343.davem@davemloft.net>
Date:   Wed, 29 Nov 2017 09:14:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     skhare@...are.com
Cc:     pv-drivers@...are.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] vmxnet3: increase default rx ring sizes

From: Shrikrishna Khare <skhare@...are.com>
Date: Tue, 28 Nov 2017 13:12:04 -0800

> We often notice rx packet drops due to small default rx ring sizes and
> solve the problem by increasing the ring sizes. This patch increases the
> default rx ring sizes thereby reducing the probability of rx packet
> drops out of the box.
> 
> Signed-off-by: Shrikrishna Khare <skhare@...are.com>
> Acked-by: Jin Heo <heoj@...are.com>
> Acked-by: Guolin Yang <gyang@...are.com>
> Acked-by: Boon Ang <bang@...are.com>

That's not enough for me.

If you're going to quadruple your default RX ring size I want to
hear more about the research you did into the packet drops and
whether other things can be done to solve the problem.

Is something holding onto the packets unnecessarily long?

Is something blocking interrupts (hardware or software)?

Is an offload miscoded or misbehaving?

Is there a problem with the RX ring replenish algorithm of the
driver or it's heuristics?

Tell me more about that than just "bumping the RX ring
size fixes the problem".

Thank you.