linux-kernel - Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171129095309.6e0a445a@gandalf.local.home>
Date:   Wed, 29 Nov 2017 09:53:09 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Vladislav Valtchev <vladislav.valtchev@...il.com>
Cc:     linux-kernel@...r.kernel.org, y.karadz@...il.com
Subject: Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from
 trace_record()

On Tue, 28 Nov 2017 20:17:46 +0200
Vladislav Valtchev <vladislav.valtchev@...il.com> wrote:

> On Tue, 2017-11-28 at 11:48 -0500, Steven Rostedt wrote:
> > 
> > Is there a reason that init_instance() isn't called in
> > init_common_record_context()?
> >   
> 
> Hi Steven,
> 
> init_instance() has been put into init_common_record_context() later,
> in patch 8, "Making start,extract,stream,profile separate funcs".

I have to ask. Why isn't it done in this patch. This patch appears to
be the proper place to put it.

-- Steve