linux-kernel - Re: [PATCH v2] arch: arm: mach-stm32: Fix copyright

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOFm3uHk3+WniPNTH82Lc8O+J3ywEYF1fy4raREFkY0p4Mvqcw@mail.gmail.com>
Date:   Wed, 29 Nov 2017 16:16:11 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     linux@...linux.org.uk, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>,
        Benjamin Gaignard <benjamin.gaignard@...com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2] arch: arm: mach-stm32: Fix copyright

On Wed, Nov 29, 2017 at 3:55 PM, Benjamin Gaignard
<benjamin.gaignard@...aro.org> wrote:
> Uniformize STMicroelectronics copyrights header
> Add SPDX identifier
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
> ---
>  arch/arm/mach-stm32/board-dt.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c
> index e918686e4191..b01f40543e6e 100644
> --- a/arch/arm/mach-stm32/board-dt.c
> +++ b/arch/arm/mach-stm32/board-dt.c
> @@ -1,5 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * Copyright (C) Maxime Coquelin 2015
> + * Copyright (C) STMicroelectronics SA 2017
>   * Author:  Maxime Coquelin <mcoquelin.stm32@...il.com>
>   * License terms:  GNU General Public License (GPL), version 2
>   */

My 2 cents:
Linus commented on the comment style and unless the code demands /**/
comments as in a few .h also used in assembly, the style to use should
be a top level line this way:

> +// SPDX-License-Identifier: GPL-2.0

You can check the rationale in recent threads on this very topic.
Thomas (tglx) also wrote the doc on this.

-- 
Cordially
Philippe Ombredanne