linux-kernel - RE: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3d2884bce244b0fa286cc5d1c07e23e@AcuMS.aculab.com>
Date:   Wed, 29 Nov 2017 16:51:20 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Andy Lutomirski' <luto@...nel.org>
CC:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        Borislav Petkov <bp@...en8.de>
Subject: RE: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling
 with IRQ state tracing enabled

From: Andy Lutomirski
> Sent: 29 November 2017 16:23
> > I can't remember what happens when swapgs itself faults.
...
> SWAPGS never faults.

Ah yes, I remember, it only restores the offset.
For 32bit processes you need to do a 'pop %gs' to recover
the segment register itself - and that can fault.

SWAPGS is a PITA. The hardware designers should have tried to write
all the interrupt handling code.

	David