linux-kernel - Re: [PATCH v8 07/13] slimbus: Add support for 'clock-pause' feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2017 20:25:26 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Srini Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark <broonie@...nel.org>, ALSA <alsa-devel@...a-project.org>,
        Sagar Dharia <sdharia@...eaurora.org>, bp@...e.de,
        poeschel@...onage.de, treding@...dia.com, andreas.noever@...il.com,
        alan@...ux.intel.com, mathieu.poirier@...aro.org, daniel@...ll.ch,
        jkosina@...e.cz, sharon.dvir1@...l.huji.ac.il,
        Joe Perches <joe@...ches.com>,
        "David S. Miller" <davem@...emloft.net>, james.hogan@...tec.com,
        michael.opdenacker@...e-electrons.com,
        Rob Herring <robh+dt@...nel.org>, pawel.moll@....com,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v8 07/13] slimbus: Add support for 'clock-pause' feature

On Thu, Nov 30, 2017 at 6:41 PM,  <srinivas.kandagatla@...aro.org> wrote:
[]
> diff --git a/drivers/slimbus/sched.c b/drivers/slimbus/sched.c
> new file mode 100644
> index 000000000000..74300f1a6898
> --- /dev/null
> +++ b/drivers/slimbus/sched.c
> @@ -0,0 +1,128 @@
> +/* Copyright (c) 2011-2016, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.

Could it make sense to use the new SPDX ids here? e.g.

> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2011-2016, The Linux Foundation

This neat and cleaner, is it?
See tglx doc posted as patches and Linus comments for a rationale on
the comment styles.
--
Cordially
Philippe Ombredanne