linux-kernel - Re: [PATCH v2] NTB: ntb_tool: Add full multi-port NTB API support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <644da251-a309-14dc-02b2-cf565b3e3e17@deltatee.com>
Date:   Thu, 30 Nov 2017 15:23:53 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Serge Semin <fancer.lancer@...il.com>, jdmason@...zu.us,
        dave.jiang@...el.com, Allen.Hubbe@....com,
        Shyam-sundar.S-k@....com, Xiangliang.Yu@....com
Cc:     Sergey.Semin@...latforms.ru, linux-ntb@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] NTB: ntb_tool: Add full multi-port NTB API support

On 30/11/17 02:37 PM, Serge Semin wrote:
> Changelog v2:
> - Remove driver Author/Description/License macros

This patch is already very long and should be split up, and you added 
more to it? If you want to fix these macros it should be in it's own 
patch with it's own justification.

> -	u64 db_bits;
>   	char *buf, cmd;
> -	ssize_t rc;
> +	ssize_t ret;

I commented on this last time we saw these patches and changing the 
variable name from 'rc' to 'ret' (in a number of places) is unnecessary 
and just adds to the noise of an already gigantic patch. I'm personally 
not going to review it further until I see a cleaner easier to read 
patch or series.

Logan