linux-kernel - Re: [PATCH 02/08] NTB: ntb_test: Add ntb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f9198e4-24d4-88f5-89d2-d36c5afa76ef@deltatee.com>
Date:   Thu, 30 Nov 2017 15:37:13 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Serge Semin <fancer.lancer@...il.com>, jdmason@...zu.us,
        dave.jiang@...el.com, Allen.Hubbe@....com,
        Shyam-sundar.S-k@....com, Xiangliang.Yu@....com
Cc:     Sergey.Semin@...latforms.ru, linux-ntb@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/08] NTB: ntb_test: Add ntb_tool port tests

On 30/11/17 02:42 PM, Serge Semin wrote:
> +function find_pidx()
> +{
> +	PORT=$1
> +	PPATH=$2
> +
> +	for ((i = 0; i < 64; i++)); do
> +		PEER_DIR="$PPATH/peer$i"
> +
> +		check_file ${PEER_DIR} || break
> +
> +		PEER_PORT=$(read_file "${PEER_DIR}/port")
> +		if [[ ${PORT} -eq $PEER_PORT ]]; then
> +			echo $i
> +			return 0
> +		fi
> +	done
> +
> +	return 1
> +}

Actually, per my earlier comments on other messages. I think it would be 
best if each of the patches in this series also included the relevant 
changes to ntb_tool. Then just ditch the ntb_tool patch. For example, 
this patch would include adding the "port" file to ntb_tool and the 
relevant test to ntb_test.

Otherwise, when the ntb_tool patch is committed, the ntb_test breaks and 
then is fixed in subsequent patches. In an ideal world, this would be 
avoided in case we ever want to do a bisect involving ntb_test.

Logan