linux-kernel - Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwtc+_ohqvFXZC6rqWbOEL1SbLF-oR=v+x+2Y2oVr+cuQ@mail.gmail.com>
Date:   Wed, 29 Nov 2017 19:27:45 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Anna Schumaker <Anna.Schumaker@...app.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [BUILD FAILURE] nfs4state.c fails to compile with gcc 4.5.4

On Wed, Nov 29, 2017 at 6:58 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>
> Seems it can't handle the initialization of an anonymous struct within
> an anonymous union.

I think we've seen this before, and I think there was some trick to
make it work with older gcc versions.

Maybe the unnamed entry that gets initialized had to be declared
first, and the initializer needed an extra set of braces?

Something like that.

But maybe the answer is just to say "4.5.4 is really old".

Doing some log digging gives me

    ee9d3429c0e4 ("net/sched/sch_red.c: work around gcc-4.4.4 anon
union initializer issue")
    aa4bf44dc851 ("userns: use union in {g,u}idmap struct")
    6c09ffd02725 ("irqchip/gic-v4: Fix building with ancient gcc")
    c848c49a62b3 ("drivers/media/cec/cec-adap.c: fix build with gcc-4.4.4")

but they aren't necessarily _exactly_ the same issue.

            Linus