linux-kernel - Re: [PATCH] staging: xgifb: remove unused macro XGIPART3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171130055544.zumzsypzwzssozts@mwanda>
Date:   Thu, 30 Nov 2017 08:55:44 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Joshua Abraham <j.abraham1776@...il.com>
Cc:     arnaud.patard@...-net.org, kstewart@...uxfoundation.org,
        devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, pombredanne@...b.com,
        tglx@...utronix.de
Subject: Re: [PATCH] staging: xgifb: remove unused macro XGIPART3

On Wed, Nov 29, 2017 at 09:53:48PM -0500, Joshua Abraham wrote:
> Signed-off-by: Joshua Abraham <j.abraham1776@...il.com>
> 
> This patch removes the unused macro XGIPART3.
> 

The Signed-off-by line goes after the changelog.

> ---
>  drivers/staging/xgifb/XGI_main.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h
> index a3af1cbbf8ee..5f55d0a39bc1 100644
> --- a/drivers/staging/xgifb/XGI_main.h
> +++ b/drivers/staging/xgifb/XGI_main.h
> @@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table);
>  #define XGIDACD			  (xgifb_info->dev_info.P3c9)
>  #define XGIPART1		  (xgifb_info->dev_info.Part1Port)
>  #define XGIPART2		  (xgifb_info->dev_info.Part2Port)
> -#define XGIPART3		  (xgifb_info->dev_info.Part3Port)

That define isn't hurting anyone.

>  #define XGIPART4		  (xgifb_info->dev_info.Part4Port)
>  #define XGIPART5		  (xgifb_info->dev_info.Part5Port)

Actually these should all be deleted because they mean you have to have
a xgifb_info variable and they hurt readability by hiding stuff behind a
define.  It would be better to remove them all than to just remove one
from the middle.  That's a more complicated patch, but it's a useful
patch.

regards,
dan carpenter