lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 30 Nov 2017 08:57:11 +0100
From:   Mathieu Malaterre <malat@...ian.org>
To:     David Daney <ddaney@...iumnetworks.com>
Cc:     Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Marco Franchi <marco.franchi@....com>,
        linux-mips@...ux-mips.org
Subject: Re: [PATCH] dt-bindings: Remove leading 0x from bindings notation

Hi David,

On Thu, Nov 30, 2017 at 12:21 AM, David Daney <ddaney@...iumnetworks.com> wrote:
> On 11/29/2017 12:55 PM, Mathieu Malaterre wrote:
>>
>> Improve the binding example by removing all the leading 0x to fix the
>> following dtc warnings:
>>
>> Warning (unit_address_format): Node /XXX unit name should not have leading
>> "0x"
>
>
> How does it fix the warnings?  You are not changing the .dts files that are
> compiled.

I originally only wanted to fix [...]watchdog/ingenic,jz4740-wdt.txt,
but when I lookup git log, I eventually found out about the commit I
refer to in my commit message:

https://github.com/torvalds/linux/commit/48c926cd3414

and I simply followed suggestion from Rob:

https://lkml.org/lkml/2017/11/1/965

> This may also cause the binding documentation to differ from the reality of
> what the actual device trees contain.


Chicken or the egg dilemma, but you understand that linux master tree
still has the original warning:

$ perl -p -i -e 's/\@0+([0-9a-f])/\@$1/g' `find ./ -type f \( -iname
\*.dtsi -o -iname \*.dts \)`
$ git diff | diffstat
[...]
 40 files changed, 160 insertions(+), 160 deletions(-)

And those are real W=1 actual warnings. Do you want me to re-submit it
as patch series instead which fix both the documentation side and the
dts* files ?


>
>>
>> Converted using the following command:
>>
>> find Documentation/devicetree/bindings -name "*.txt" -exec sed -i -e
>> 's/([^ ])\@0x([0-9a-f])/$1\@$2/g' {} +
>>
>> This is a follow up to commit 48c926cd3414
>>
>> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
>> ---
>> I've also checked using the original perl command that I did not
>> introduce:
>>
>> Warning (unit_address_format): Node /XXX unit name should not have leading
>> 0s
>>
>>   Documentation/devicetree/bindings/arm/ccn.txt                |  2 +-
>>   Documentation/devicetree/bindings/arm/omap/crossbar.txt      |  2 +-
>>   .../devicetree/bindings/arm/tegra/nvidia,tegra20-mc.txt      |  2 +-
>>   Documentation/devicetree/bindings/clock/axi-clkgen.txt       |  2 +-
>>   .../devicetree/bindings/clock/brcm,bcm2835-aux-clock.txt     |  2 +-
>>   Documentation/devicetree/bindings/clock/exynos4-clock.txt    |  2 +-
>>   Documentation/devicetree/bindings/clock/exynos5250-clock.txt |  2 +-
>>   Documentation/devicetree/bindings/clock/exynos5410-clock.txt |  2 +-
>>   Documentation/devicetree/bindings/clock/exynos5420-clock.txt |  2 +-
>>   Documentation/devicetree/bindings/clock/exynos5440-clock.txt |  2 +-
>>   .../devicetree/bindings/clock/ti-keystone-pllctrl.txt        |  2 +-
>>   Documentation/devicetree/bindings/clock/zx296702-clk.txt     |  4 ++--
>>   Documentation/devicetree/bindings/crypto/fsl-sec4.txt        |  4 ++--
>>   .../devicetree/bindings/devfreq/event/rockchip-dfi.txt       |  2 +-
>>   Documentation/devicetree/bindings/display/atmel,lcdc.txt     |  4 ++--
>>   Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt    |  4 ++--
>>   Documentation/devicetree/bindings/dma/zxdma.txt              |  2 +-
>>   Documentation/devicetree/bindings/gpio/gpio-altera.txt       |  2 +-
>>   Documentation/devicetree/bindings/i2c/i2c-jz4780.txt         |  2 +-
>>   Documentation/devicetree/bindings/iio/pressure/hp03.txt      |  2 +-
>>   .../devicetree/bindings/input/touchscreen/bu21013.txt        |  2 +-
>>   .../devicetree/bindings/interrupt-controller/arm,gic.txt     |  4 ++--
>>   .../bindings/interrupt-controller/img,meta-intc.txt          |  2 +-
>>   .../bindings/interrupt-controller/img,pdc-intc.txt           |  2 +-
>>   .../bindings/interrupt-controller/st,spear3xx-shirq.txt      |  2 +-
>>   Documentation/devicetree/bindings/mailbox/altera-mailbox.txt |  6 +++---
>>   .../devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt      |  2 +-
>>   Documentation/devicetree/bindings/media/exynos5-gsc.txt      |  2 +-
>>   Documentation/devicetree/bindings/media/mediatek-vcodec.txt  |  2 +-
>>   Documentation/devicetree/bindings/media/rcar_vin.txt         |  2 +-
>>   Documentation/devicetree/bindings/media/samsung-fimc.txt     |  2 +-
>>   Documentation/devicetree/bindings/media/sh_mobile_ceu.txt    |  2 +-
>>   Documentation/devicetree/bindings/media/video-interfaces.txt | 10
>> +++++-----
>>   .../devicetree/bindings/memory-controllers/ti/emif.txt       |  2 +-
>>   .../devicetree/bindings/mfd/ti-keystone-devctrl.txt          |  2 +-
>>   Documentation/devicetree/bindings/misc/brcm,kona-smc.txt     |  2 +-
>>   Documentation/devicetree/bindings/mmc/brcm,kona-sdhci.txt    |  2 +-
>>   Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt   |  2 +-
>>   Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt      |  4 ++--
>>   Documentation/devicetree/bindings/mtd/gpmc-nor.txt           |  6 +++---
>>   Documentation/devicetree/bindings/mtd/mtk-nand.txt           |  2 +-
>>   Documentation/devicetree/bindings/net/altera_tse.txt         |  4 ++--
>>   Documentation/devicetree/bindings/net/mdio.txt               |  2 +-
>>   Documentation/devicetree/bindings/net/socfpga-dwmac.txt      |  2 +-
>>   Documentation/devicetree/bindings/nios2/nios2.txt            |  2 +-
>>   Documentation/devicetree/bindings/pci/altera-pcie.txt        |  2 +-
>>   Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt     |  2 +-
>>   Documentation/devicetree/bindings/pci/hisilicon-pcie.txt     |  2 +-
>>   Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt      |  2 +-
>>   .../devicetree/bindings/pinctrl/brcm,cygnus-pinmux.txt       |  2 +-
>>   Documentation/devicetree/bindings/pinctrl/pinctrl-atlas7.txt |  4 ++--
>>   Documentation/devicetree/bindings/pinctrl/pinctrl-sirf.txt   |  2 +-
>>   .../devicetree/bindings/pinctrl/rockchip,pinctrl.txt         |  4 ++--
>>   Documentation/devicetree/bindings/regulator/regulator.txt    |  2 +-
>>   Documentation/devicetree/bindings/serial/efm32-uart.txt      |  2 +-
>>   .../devicetree/bindings/serio/allwinner,sun4i-ps2.txt        |  2 +-
>>   .../devicetree/bindings/soc/ti/keystone-navigator-qmss.txt   |  2 +-
>>   Documentation/devicetree/bindings/sound/adi,axi-i2s.txt      |  2 +-
>>   Documentation/devicetree/bindings/sound/adi,axi-spdif-tx.txt |  2 +-
>>   Documentation/devicetree/bindings/sound/ak4613.txt           |  2 +-
>>   Documentation/devicetree/bindings/sound/ak4642.txt           |  2 +-
>>   Documentation/devicetree/bindings/sound/max98371.txt         |  2 +-
>>   Documentation/devicetree/bindings/sound/max9867.txt          |  2 +-
>>   Documentation/devicetree/bindings/sound/renesas,fsi.txt      |  2 +-
>>   Documentation/devicetree/bindings/sound/rockchip-spdif.txt   |  2 +-
>>   Documentation/devicetree/bindings/sound/st,sti-asoc-card.txt |  8
>> ++++----
>>   Documentation/devicetree/bindings/spi/efm32-spi.txt          |  2 +-
>>   Documentation/devicetree/bindings/thermal/thermal.txt        | 12
>> ++++++------
>>   Documentation/devicetree/bindings/ufs/ufs-qcom.txt           |  4 ++--
>>   Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt      |  2 +-
>>   Documentation/devicetree/bindings/usb/ehci-st.txt            |  2 +-
>>   Documentation/devicetree/bindings/usb/ohci-st.txt            |  2 +-
>>   .../devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt      |  2 +-
>>   73 files changed, 99 insertions(+), 99 deletions(-)
>>
>

Powered by blists - more mailing lists