linux-kernel - Re: [PATCH] mmc: block: make function mmc_cqe_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <969757e5-79e3-c12c-259f-9461b5a40f34@intel.com>
Date:   Thu, 30 Nov 2017 13:45:10 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Colin King <colin.king@...onical.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-mmc@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: block: make function mmc_cqe_issue_type static

On 30/11/17 13:37, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function mmc_cqe_issue_type is local to the source and does
> not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type'
> was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/core/queue.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index d8394007bc99..5db388081789 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
>  	return host->caps2 & MMC_CAP2_CQE_DCMD;
>  }
>  
> -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> -				       struct request *req)
> +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host,
> +					      struct request *req)
>  {
>  	switch (req_op(req)) {
>  	case REQ_OP_DRV_IN:
>