linux-kernel - Re: [PATCH v3 4/9] KVM: x86: Add Intel Processor Trace cpuid emulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46f714d9-a8be-4f62-1f92-21b2a3f12009@redhat.com>
Date:   Thu, 30 Nov 2017 13:17:01 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Luwei Kang <luwei.kang@...el.com>, kvm@...r.kernel.org
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, rkrcmar@...hat.com, linux-kernel@...r.kernel.org,
        joro@...tes.org, Chao Peng <chao.p.peng@...ux.intel.com>
Subject: Re: [PATCH v3 4/9] KVM: x86: Add Intel Processor Trace cpuid
 emulation

On 27/11/2017 21:23, Luwei Kang wrote:
> +		int t, times = entry->eax & 0xffffffff;

This AND is not necessary.

Paolo

> +
> +		if (!f_intel_pt)
> +			break;
> +
> +		entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
> +		for (t = 1; t <= times; ++t) {
> +			if (*nent >= maxnent)
> +				goto out;
> +			do_cpuid_1_ent(&entry[t], function, t);
> +			entry[t].flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
> +			++*nent;
> +		}
> +		break;
> +	}