linux-kernel - Re: [PATCH] usbip: fix usbip attach to find a port that matches the requested speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09e82933-981b-0cef-3364-baa04aa9a4c3@kernel.org>
Date:   Thu, 30 Nov 2017 07:56:45 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Shuah Khan <shuahkh@....samsung.com>
Cc:     valentina.manea.m@...il.com, yuyang.du@...el.com,
        k.opasiak@...sung.com, kstewart@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        juan.zea@...del.com, Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] usbip: fix usbip attach to find a port that matches the
 requested speed

On 11/30/2017 01:20 AM, Greg KH wrote:
> On Wed, Nov 29, 2017 at 03:24:22PM -0700, Shuah Khan wrote:
>> usbip attach fails to find a free port when the device on the first port
>> is a USB_SPEED_SUPER device and non-super speed device is being attached.
>> It keeps checking the first port and returns without a match getting stuck
>> in a loop.
>>
>> Fix it check to find the first port with matching speed.
>>
>> Reported-by: Juan Zea <juan.zea@...del.com>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  tools/usb/usbip/libsrc/vhci_driver.c | 14 +++++++++++---
>>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> Does this need to go to the stable trees?
> 

Yes it does. I forgot to tag this for stable. There is another
one from Yuyang Du that needs to go into stable. I am just about
to Ack that. These need to go tino 4.13 as well, but looks like
4.13 is all done now. So definitely for 4.14

[PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather

thanks,
-- Shuah