linux-kernel - Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Nov 2017 08:00:06 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     Yuyang Du <yuyang.du@...el.com>, valentina.manea.m@...il.com
Cc:     gregkh@...uxfoundation.org, k.opasiak@...sung.com,
        kstewart@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, juan.zea@...del.com,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of
 scatter-gather

On 11/29/2017 07:22 PM, Yuyang Du wrote:
> The previous USB3 SuperSpeed enabling patches mistakenly enabled
> URB scatter-gather chaining, which is actually not supported by
> the VHCI HCD. This patch fixes that.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867
> Fixes: 03cd00d538a6feb ("usbip: vhci-hcd: Set the vhci structure up to work")
> Reported-by: Juan Zea <juan.zea@...del.com>
> Signed-off-by: Yuyang Du <yuyang.du@...el.com>> ---
>  drivers/usb/usbip/vhci_hcd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 713e941..6b3278c 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1098,7 +1098,6 @@ static int hcd_name_to_id(const char *name)
>  static int vhci_setup(struct usb_hcd *hcd)
>  {
>  	struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller));
> -	hcd->self.sg_tablesize = ~0;
>  	if (usb_hcd_is_primary_hcd(hcd)) {
>  		vhci->vhci_hcd_hs = hcd_to_vhci_hcd(hcd);
>  		vhci->vhci_hcd_hs->vhci = vhci;
> 

This need to go into stable as well. It applies to 4.14

Acked-by: Shuah Khan <shuahkh@....samsung.com>

thanks,
-- Shuah