linux-kernel - Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171130152430.GM28152@atomide.com>
Date:   Thu, 30 Nov 2017 07:24:30 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Tomi Valkeinen <tomi.valkeinen@...com>,
        Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Benoît Cousson <bcousson@...libre.com>,
        Russell King <linux@...linux.org.uk>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org, DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-omap <linux-omap@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-fbdev@...r.kernel.org,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>, kernel@...a-handheld.com
Subject: Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string

* H. Nikolaus Schaller <hns@...delico.com> [171128 18:35]:
> Hi,
> 
> > Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony@...mide.com>:
> > 
> > * H. Nikolaus Schaller <hns@...delico.com> [171128 16:17]:
> >> Hi Tony,
> >> 
> >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@...mide.com>:
> >>> 
> >>> * H. Nikolaus Schaller <hns@...delico.com> [171128 15:52]:
> >>>> We can remove the unnecessary "omapdss," prefix because
> >>>> the omapdrm driver takes care of it when matching with
> >>>> the driver table.
> >>> 
> >>> So is this needed as a fix or is this another clean-up?
> >>> 
> >>> So is this is really needed as a fix?
> >> 
> >> Hm. How do you differentiate between "fix" and "cleanup"?
> >> Maybe it is more a wording than a content issue...
> >> 
> >> For me it is a "fix" because it is semantically wrong to have
> >> a prefix where it is not needed. And "fixing" it changes the
> >> compiler output by 8 bytes.
> > 
> > How about let's call it a "typo fix" then? :)
> 
> Well, it is not really a typo.

Well what if the stable people pick it into earlier stable series
based on the word fix in the subject? That has happened before.

I suggest you update the dts patches to use wording like
"update compatible to use new naming" or something similar.

Regards,

Tony