linux-kernel - Re: [PATCH v2 11/18] drm/sun4i: Add A83T support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171130153312.plmh2wr4n5njhlvb@flea.lan>
Date:   Thu, 30 Nov 2017 16:33:12 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Jernej Škrabec <jernej.skrabec@...l.net>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        David Airlie <airlied@...ux.ie>, Chen-Yu Tsai <wens@...e.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        plaes@...es.org, icenowy@...c.io,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Subject: Re: [PATCH v2 11/18] drm/sun4i: Add A83T support

On Tue, Nov 28, 2017 at 11:33:44PM +0100, Jernej Škrabec wrote:
> Hi!
> 
> Dne torek, 28. november 2017 ob 23:00:14 CET je Maxime Ripard napisal(a):
> > On Tue, Nov 28, 2017 at 04:48:55PM +0100, Jernej Škrabec wrote:
> > > > On Mon, Nov 27, 2017 at 05:01:49PM +0100, Jernej Škrabec wrote:
> > > > > Dne ponedeljek, 27. november 2017 ob 16:41:35 CET je Maxime Ripard
> > > 
> > > napisal(a):
> > > > > > Add support for the A83T display pipeline.
> > > > > > 
> > > > > > Reviewed-by: Chen-Yu Tsai <wens@...e.org>
> > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > > > > > ---
> > > > > > 
> > > > > >  Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3
> > > > > >  +++
> > > > > >  drivers/gpu/drm/sun4i/sun4i_drv.c                             | 2
> > > > > >  ++
> > > > > >  drivers/gpu/drm/sun4i/sun4i_tcon.c                            | 5
> > > > > >  +++++
> > > > > >  drivers/gpu/drm/sun4i/sun8i_mixer.c                           | 4
> > > > > >  ++++
> > > > > >  4 files changed, 14 insertions(+)
> > > > > > 
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > > > > > b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > > > > > index
> > > > > > d4259a4f5171..d6b52e5c48c0 100644
> > > > > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > > > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > > > > > 
> > > > > > @@ -93,6 +93,7 @@ Required properties:
> > > > > >     * allwinner,sun6i-a31s-tcon
> > > > > >     * allwinner,sun7i-a20-tcon
> > > > > >     * allwinner,sun8i-a33-tcon
> > > > > > 
> > > > > > +   * allwinner,sun8i-a83t-tcon-lcd
> > > > > > 
> > > > > >     * allwinner,sun8i-v3s-tcon
> > > > > >   
> > > > > >   - reg: base address and size of memory-mapped region
> > > > > >   - interrupts: interrupt associated to this IP
> > > > > > 
> > > > > > @@ -224,6 +225,7 @@ supported.
> > > > > > 
> > > > > >  Required properties:
> > > > > >    - compatible: value must be one of:
> > > > > > +    * allwinner,sun8i-a83t-de2-mixer
> > > > > 
> > > > > What will be the name of the second mixer, once support for HDMI is
> > > > > added?
> > > > > Should we start directly with 0 and 1 postfix ?
> > > > 
> > > > What are the differences exactly without the two mixers?
> > > 
> > > Mixer properties:
> > > - mixer index (0 or 1), important for determining CCSC base (see my
> > > patches)
> > Is that the only thing we need to determine?
> 
> For now, mixer index is important only for determining CCSC base in conjuction 
> with VEP capability. Obviously, I can't exclude that there is some other case 
> where that mixer index is needed.

That's unfortunate...

> Can't we just add reg property for that?

No, reg is here specifically for the bus address, not for an index,
and in general, indices are poorly perceived and have been subject to
a lot of debate in the past. Hence why I'd really like to avoid any
solution looking like this. But I guess we don't really have the
choice either.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)