linux-kernel - Re: [PATCH v1] USB: storage: Remove obsolete "FIXME"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1711301057260.1380-100000@iolanthe.rowland.org>
Date:   Thu, 30 Nov 2017 10:57:35 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Mikhail Zaytsev <flashed@...l.ru>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>,
        <usb-storage@...ts.one-eyed-alien.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] USB: storage: Remove obsolete "FIXME"

On Thu, 30 Nov 2017, Mikhail Zaytsev wrote:

> The fix of "FIXME: Notify the subdrivers..." doesn't actually have any
>  real effect. The "FIXME" changed to simple comment. 
> 
> Signed-off-by: Mikhail Zaytsev <flashed@...l.ru>
> ---
>  drivers/usb/storage/usb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index a0c07e0..3eb9347 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -211,8 +211,8 @@ int usb_stor_reset_resume(struct usb_interface *iface)
>  	usb_stor_report_bus_reset(us);
>  
>  	/*
> -	 * FIXME: Notify the subdrivers that they need to reinitialize
> -	 * the device
> +	 * If any of the subdrivers implemented a reinitialization scheme,
> +	 * this is where the callback would be invoked.
>  	 */
>  	return 0;
>  }
> @@ -243,8 +243,8 @@ int usb_stor_post_reset(struct usb_interface *iface)
>  	usb_stor_report_bus_reset(us);
>  
>  	/*
> -	 * FIXME: Notify the subdrivers that they need to reinitialize
> -	 * the device
> +	 * If any of the subdrivers implemented a reinitialization scheme,
> +	 * this is where the callback would be invoked.
>  	 */
>  
>  	mutex_unlock(&us->dev_mutex);

Acked-by: Alan Stern <stern@...land.harvard.edu>