linux-kernel - Re: [PATCH] x86/power: Fix some ordering bugs in __restore_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrWdx7yRcKu3svcrQczjyGy_oXgjc9NcHbf_Bba9psKETw@mail.gmail.com>
Date:   Thu, 30 Nov 2017 07:59:34 -0800
From:   Andy Lutomirski <luto@...nel.org>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     X86 ML <x86@...nel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] x86/power: Fix some ordering bugs in __restore_processor_context()

On Thu, Nov 30, 2017 at 7:57 AM, Andy Lutomirski <luto@...nel.org> wrote:
> __restore_processor_context() had a couple of ordering bugs.  It
> restored GSBASE after calling load_gs_index(), and the latter can
> call into tracing code.  It also tried to restore segment registers
> before restoring the LDT, which is straight-up wrong.

Ingo, Thomas, if you apply this version, can you fix up the following
changelog bug:

>                 .seg_not_present = 1,

That should be = 0 above.

If I send a v2, I'll fix it.