lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171130164445.GA4238@castle.DHCP.thefacebook.com> Date: Thu, 30 Nov 2017 16:44:52 +0000 From: Roman Gushchin <guro@...com> To: David Ahern <dsahern@...il.com> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <kernel-team@...com>, <ast@...nel.org>, <daniel@...earbox.net>, <jakub.kicinski@...ronome.com>, <kafai@...com> Subject: Re: [PATCH net-next 3/5] bpftool: implement cgattach command On Thu, Nov 30, 2017 at 09:17:17AM -0700, David Ahern wrote: > On 11/30/17 6:43 AM, Roman Gushchin wrote: > > @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv) > > fprintf(stderr, > > "Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n" > > " %s batch file FILE\n" > > + " %s cgattach FILE CGROUP TYPE\n" > > Can you change the order to: > + " %s cgattach CGROUP TYPE FILE\n" > > Makes for better consistency with the detach command in the next patch: > + " %s cgdetach CGROUP TYPE ID\n" > > Good point. I'll fix this and will add support for attach_flags in v2. Thanks!
Powered by blists - more mailing lists