linux-kernel - Re: [PATCH v2] tpm: return a TPM_RC_COMMAND_CODE response if a command isn't implemented

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7df9ad8d-08b7-2be1-ebd8-874777aaed98@twobit.us>
Date:   Wed, 29 Nov 2017 17:45:49 -0800
From:   Philip Tricca <flihp@...bit.us>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Javier Martinez Canillas <javierm@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Peter Huewe <peterhuewe@....de>,
        Jerry Snitselaar <jsnitsel@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Philip Tricca <philip.b.tricca@...el.com>,
        linux-integrity@...r.kernel.org,
        William Roberts <william.c.roberts@...el.com>,
        James Bottomley <James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH v2] tpm: return a TPM_RC_COMMAND_CODE response if a
 command isn't implemented

On 11/29/2017 09:57 AM, Jarkko Sakkinen wrote:
> On Wed, Nov 29, 2017 at 12:08:46PM +0100, Javier Martinez Canillas wrote:
>> +#define TPM2_RC_LAYER_SHIFT	16
>> +#define TPM2_RESMGRTPM_RC_LAYER (11 << TPM2_RC_LAYER_SHIFT)
> 
> I got this spec from Philip [1].

As part of this I've been doing a pass back over the current draft spec
fixing up all of the places where the we were using 'ERROR_LEVEL',
'RESPONSE_LEVEL' etc interchangeably. Everything will be 'RC_LAYER' in
the next published draft. Apologies if this caused any confusion here
but it looks like Javier was able to work around this regardless Next
time around the spec should be more clear.

Philip

> Couple of remarks:
> 
> * What is the difference between TSS2_RESMGR_RC_LAYER and
>   TSS2_RESMGR_TPM_RC_LAYER?
> * Should the driver code use TSS2 or TPM2 prefix?
> 
> [1] https://trustedcomputinggroup.org/wp-content/uploads/TCG-TSS-2.0-Overview-and-Common-Structures-Specification-Version-0.90-Revision-02.pdf
> 
> /Jarkko
>