linux-kernel - RE: [PATCH] iw_cxgb4: make pointer reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com>
Date:   Thu, 30 Nov 2017 10:41:50 -0600
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Colin King'" <colin.king@...onical.com>,
        "'Steve Wise'" <swise@...lsio.com>,
        "'Doug Ledford'" <dledford@...hat.com>,
        "'Jason Gunthorpe'" <jgg@...pe.ca>, <linux-rdma@...r.kernel.org>
Cc:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <bharat@...lsio.com>
Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static

> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer reg_workq is local to the source and does not need to be
> in global scope, so make it static.
> 
> Cleans up sparse warning:
> drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq'
> was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Looks correct.  This fixes a recent commit.

Reviewed-by: Steve Wise <swise@...ngridcomputing.com>
Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning")

Thanks,

Steve.