linux-kernel - Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201053510.GZ28761@minitux>
Date:   Thu, 30 Nov 2017 21:35:10 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Arun Kumar Neelakantam <aneela@...eaurora.org>,
        Chris Lew <clew@...eaurora.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

On Thu 30 Nov 00:18 PST 2017, Philippe Ombredanne wrote:

> Bjorn,
> 
> On Thu, Nov 30, 2017 at 2:16 AM, Bjorn Andersson
> <bjorn.andersson@...aro.org> wrote:
> []
> > diff --git a/drivers/soc/qcom/qmi_interface.c b/drivers/soc/qcom/qmi_interface.c
> > new file mode 100644
> > index 000000000000..4027b52b0834
> > --- /dev/null
> > +++ b/drivers/soc/qcom/qmi_interface.c
> > @@ -0,0 +1,857 @@
> > +/*
> > + * Copyright (C) 2017 Linaro Ltd.
> > + *
> > + * This software is licensed under the terms of the GNU General Public
> > + * License version 2, as published by the Free Software Foundation, and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> 
> Could it make sense, especially for new files, to use the new SPDX ids
> and avoid adding boilerplate that will need to be cleaned up later?
> e.g. something like this instead, using the new conventions started by
> greg-kh and by documented tglx?
> 
> NB: the // comment  style is not a mistake and is what Linus wants
> there. See the threads on this topic.
> 
> > @@ -0,0 +1,857 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2017 Linaro Ltd.
> > + */
> 
> Isn't this shorter and better? :P
> 

That sounds very reasonable, I will update the patches.

> BTW, if you need help to fix this on the rest of Linaro contributed
> code, I maintain a tool that can help there.
> 

I haven't seen any guidelines on how this should be introduced
throughout the kernel, should I make a similar push for the subsystems I
maintain?

Regards,
Bjorn