linux-kernel - Re: [PATCH net-next 2/3] xfrm: Fix xfrm_dev_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Dec 2017 07:21:08 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <yossefe@...lanox.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <borisp@...lanox.com>, <kliteyn@...lanox.com>,
        <yossiku@...lanox.com>
Subject: Re: [PATCH net-next 2/3] xfrm: Fix xfrm_dev_state_add to fail for
 unsupported HW SA option

On Tue, Nov 28, 2017 at 11:49:29AM +0200, yossefe@...lanox.com wrote:
> From: Yossef Efraim <yossefe@...lanox.com>
> 
> xfrm_dev_state_add function returns success for unsupported HW SA options.
> Resulting the calling function to create SW SA without corrlating HW SA.
> Desipte IPSec device offloading option was chosen.
> These not supported HW SA options are hard coded within xfrm_dev_state_add
> function.
> SW backward compatibility will break if we add any of these option as old
> HW will fail with new SW.
> 
> This patch changes the behaviour to return -EINVAL in case unsupported
> option is chosen.
> Notifying user application regarding failure and not breaking backward
> compatibility for newly added HW SA options.
> 
> Signed-off-by: Yossef Efraim <yossefe@...lanox.com>

Also applied to ipsec-next, thanks a lot!