linux-kernel - Re: [PATCH v2] leds: pm8058: Silence pointer to integer size warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201083642.GA4960@amd>
Date:   Fri, 1 Dec 2017 09:36:42 +0100
From:   Pavel Machek <pavel@....cz>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH v2] leds: pm8058: Silence pointer to integer size warning

On Fri 2017-12-01 07:57:15, Lee Jones wrote:
> On Thu, 30 Nov 2017, Bjorn Andersson wrote:
> 
> > The pointer returned by of_device_get_match_data() doesn't have the same
> > size as u32 on 64-bit architectures, causing a compile warning when
> > compile-testing the driver on such platform.
> > 
> > Cast the return value of of_device_get_match_data() to unsigned long and
> > then to u32 to silence this warning.
> > 
> > Cc: Linus Walleij <linus.walleij@...aro.org>
> > Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver")
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Thanks!

Acked-by: Pavel Machek <pavel@....cz>

> > diff --git a/drivers/leds/leds-pm8058.c b/drivers/leds/leds-pm8058.c
> > index a52674327857..8988ba3b2d65 100644
> > --- a/drivers/leds/leds-pm8058.c
> > +++ b/drivers/leds/leds-pm8058.c
> > @@ -106,7 +106,7 @@ static int pm8058_led_probe(struct platform_device *pdev)
> >  	if (!led)
> >  		return -ENOMEM;
> >  
> > -	led->ledtype = (u32)of_device_get_match_data(&pdev->dev);
> > +	led->ledtype = (u32)(unsigned long)of_device_get_match_data(&pdev->dev);
> 
> Wouldn't (u32)(void *) be even more correct?
> 
> ... if the compiler will let you get away with it.

Afaict that would still produce the warning. of_device_get_match_data
already returns void *.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)